Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding method to binary mask collection that imports external labeled images #1731

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

shanaxel42
Copy link
Collaborator

@shanaxel42 shanaxel42 commented Jan 13, 2020

Ex. if someone saves the output of ilastik object classification as a tiff file

@shanaxel42 shanaxel42 changed the title Adding method to binary mask collection that imports labeled images f… Adding method to binary mask collection that imports external labeled images Jan 13, 2020
@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #1731 into master will decrease coverage by 0.04%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1731      +/-   ##
==========================================
- Coverage   90.13%   90.09%   -0.05%     
==========================================
  Files         248      248              
  Lines        9166     9175       +9     
==========================================
+ Hits         8262     8266       +4     
- Misses        904      909       +5
Impacted Files Coverage Δ
...tarfish/core/morphology/binary_mask/binary_mask.py 93% <44.44%> (-2.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d4bf2a...c0d7f4f. Read the comment docs.

@shanaxel42 shanaxel42 force-pushed the saxelrod-from-ilastick-labeled-image branch 3 times, most recently from 8a63ef8 to c0d7f4f Compare January 16, 2020 22:51
@shanaxel42 shanaxel42 requested a review from ttung January 21, 2020 18:08
@@ -262,6 +264,30 @@ def from_label_image(cls, label_image: LabelImage) -> "BinaryMaskCollection":
log,
)

@classmethod
def from_external_labeled_image(cls, path_to_labeled_image: Union[str, Path],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a docs for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!

@shanaxel42 shanaxel42 force-pushed the saxelrod-from-ilastick-labeled-image branch from c0d7f4f to 054dd28 Compare January 22, 2020 17:41
@shanaxel42 shanaxel42 merged commit 11cce4e into master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants