Add group_by for tilefetcher-based ImageStack construction #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we construct an ImageStack from a tilefetcher, we now allow accept a `group_by` parameter which controls how we load the data. If an axis is in the `group_by`, then we load all the data for any given value for that axis before moving on to another value for that axis. For instance, if Axes.ROUND is in `group_by`, then we will load all the data for round=0 before we load the data for round=1. Test plan: Added tests to verify that the loader works with a variety of `group_by`s. Dan Goodwin's 3D data loads in 100seconds now instead of 10 minutes.
Codecov Report
@@ Coverage Diff @@
## master #1796 +/- ##
==========================================
- Coverage 89.94% 89.87% -0.07%
==========================================
Files 252 252
Lines 9307 9327 +20
==========================================
+ Hits 8371 8383 +12
- Misses 936 944 +8
Continue to review full report at Codecov.
|
shanaxel42
approved these changes
Feb 7, 2020
|
@mattcai fyi this just landed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we construct an ImageStack from a tilefetcher, we now allow accept a
group_byparameter which controls how we load the data. If an axis is in thegroup_by, then we load all the data for any given value for that axis before moving on to another value for that axis.For instance, if Axes.ROUND is in
group_by, then we will load all the data for round=0 before we load the data for round=1.Test plan: Added tests to verify that the loader works with a variety of
group_bys. Dan Goodwin's 3D data loads in 100seconds now instead of 10 minutes.