fix how spot_ids are handled by build_traces_sequential and Label._assign() #1872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bug fixes:
build_traces_sequential
reassign uniquespot_id
s to every feature after concatenatingPerImageSliceResults
.Label._assign()
explicitly label features byspot_id
instead of row number, ensuring that labeling is accurate even whenspot_id
s do not match row numbers in anIntensityTable
.Spot_id
s must still be unique for accurate labeling though.