-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to provenance log #968
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5511ea3
implementation of extra log info
534867e
changing format
e56debc
changing approach for dependencies
7850516
checking for git rep first
5fbd9b4
using pkg_resources
26904fc
check for tracked git file
e4fcc71
adding starfish version
74bd003
changed git hash function
492c32b
changes.
36b4c75
adding new step
5283eaf
Merge remote-tracking branch 'origin/master' into saxelrod-logging
b33c976
testing
4e67eac
fixing makefile
24d89a2
changing git hash to release tag
1e59ad5
fixing notebook weirdness
fa77b2e
changing core dependencies to a set
e4ffa7e
changing name
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
import platform | ||
from functools import lru_cache | ||
from json import JSONEncoder | ||
from typing import Mapping | ||
|
||
import pkg_resources | ||
|
||
import starfish | ||
from starfish.types import CORE_DEPENDENCIES | ||
|
||
|
||
@lru_cache(maxsize=1) | ||
def get_core_dependency_info() -> Mapping[str, str]: | ||
dependency_info = dict() | ||
for dependency in CORE_DEPENDENCIES: | ||
version = get_dependency_version(dependency) | ||
dependency_info[dependency] = version | ||
return dependency_info | ||
|
||
|
||
def get_dependency_version(dependency: str) -> str: | ||
return pkg_resources.get_distribution(dependency).version | ||
|
||
|
||
@lru_cache(maxsize=1) | ||
def get_release_tag() -> str: | ||
if not starfish.__release_tag__: | ||
return "Running starfish from source" | ||
return starfish.__release_tag__ | ||
|
||
|
||
@lru_cache(maxsize=1) | ||
def get_os_info() -> Mapping[str, str]: | ||
return {"Platform": platform.system(), | ||
"Version:": platform.version(), | ||
"Python Version": platform.python_version()} | ||
|
||
|
||
class LogEncoder(JSONEncoder): | ||
""" | ||
JSON encodes the List[Dict] pipeline provence log. For simple | ||
objects use default JSON encoding. For more complex objects | ||
(ex. Imagestack, Codebook) encode the repr of the object. | ||
""" | ||
def default(self, o): | ||
try: | ||
return super(LogEncoder, self).default(o) | ||
except TypeError: | ||
return JSONEncoder().encode(repr(o)) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make it super explicit, e.g.,
is_released_version
or something like that.also, cc: #761