Re-enable Windows Karpenter nodes #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job scheduled on a Karpenter windows node in staging - https://gitlab.staging.spack.io/spack/spack/-/jobs/108126 |
jjnesbitt
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables Karpenter support for Windows. This will get us back to autoscaling based on load, instead of just running a couple static instances 24/7.
The issue turned out to be an IAM policy that needed to be attached to the Karpenter controller node, in order for Windows nodes to have the necessary permissions to create EC2 instance profiles. Previously, Karpenter created a static instance profile for all nodes, but starting in v1, they changed the behavior. Since we're using Karpenter for both Linux and Windows nodes, there's some complications to setting up the Terraform modules; I've expanded on the details in a code comment.