Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stesachs@amazon.com to run s3 sync on a sub-bucket #977

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

stephenmsachs
Copy link
Contributor

@stephenmsachs stephenmsachs commented Oct 18, 2024

I want to add to the existing buildcache location and run spack buildcache update-index in order to merge the content. Spack needs to be able to list the
content (or use aws s3 sync) to run buildcache update-index.

This is an extension of #731 to enable aws s3 sync additionally to aws s3 cp.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
I want to add to the existing buildcache location and run `spack buildcache
update-index` in order to merge the content. Spack needs to be able to list the
content (or use `aws s3 sync`) to run `buildcache update-index`.

This is an extension of spack#730 to enable `aws s3 sync` additionally to `aws s3 cp`.
@mvandenburgh mvandenburgh merged commit e127594 into spack:main Oct 18, 2024
5 checks passed
@mvandenburgh
Copy link
Member

mvandenburgh commented Oct 18, 2024

@stephenmsachs it looks like I merged this prematurely, AWS is saying the new bucket policy is invalid. I assumed CI would catch something like that, but it didn't - I'll figure out why this isn't working and make a follow up and ping you when it's resolved.

stephenmsachs added a commit to stephenmsachs/spack-infrastructure that referenced this pull request Oct 21, 2024
`s3:CopyObjects` and `s3:ListObjects` are not registered as IAM s3 actions. Fixes spack#977
stephenmsachs added a commit to stephenmsachs/spack-infrastructure that referenced this pull request Oct 31, 2024
Remove non-existent s3 actions

`s3:CopyObjects` and `s3:ListObjects` are not registered as IAM s3 actions. Fixes spack#977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants