Increase max_yaml_size_bytes to 50MB
#986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
requested review from
zackgalbreath,
scottwittenburg and
kwryankrattiger
scottwittenburg
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
IIUC the reason they added the limit was to protect against the billion laughs attack (reference). But 50MB isn't that much bigger than 20MB, and it buys time by allowing the stacks to more than double in size (roughly) before we run into this again. When we have the common stacks stuff set up, pipelines could become smaller in general, so maybe we could revisit then to see if we can decrease the limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://spackpm.slack.com/archives/C02N33GM28H/p1730299174926259.
We've encountered a generated pipeline yaml that exceeded the currently set limit of 20MB (https://gitlab.spack.io/spack/spack/-/pipelines/873775). That particular yaml took 20.9MB of memory, which I was able to confirm by patching the staging gitlab instance to report the memory used. (https://gitlab.staging.spack.io/mvandenburgh/spack/-/pipelines/1372)
I'm not sure what the best approach is here; I've bumped up the limit to 50MB, but technically that's a lot more than what we needed in this case. I'm not sure what the implications of a high yaml size limit are, anyone have any thoughts?