Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync script: block on "all-prechecks" #993

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

zackgalbreath
Copy link
Collaborator

Update our sync script configuration to not push Spack PR branches until the "all-prechecks" check has succeeded.

Update our sync script configuration to not push Spack PR branches
until the "all-prechecks" check has succeeded.
@scottwittenburg
Copy link
Collaborator

The change looks right to me, based on the names of checks I see. Just need to bump the image version number I think. Or is there more you plan to add?

@zackgalbreath
Copy link
Collaborator Author

The change looks right to me, based on the names of checks I see. Just need to bump the image version number I think. Or is there more you plan to add?

We're not changing the source code of the sync script, just how it gets called from the cron job. So I don't think we need a version bump this time?

@mvandenburgh
Copy link
Member

The change looks right to me, based on the names of checks I see. Just need to bump the image version number I think. Or is there more you plan to add?

We're not changing the source code of the sync script, just how it gets called from the cron job. So I don't think we need a version bump this time?

That's correct, no version bump should be needed here

Copy link
Collaborator

@kwryankrattiger kwryankrattiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, status name matches.

@zackgalbreath zackgalbreath merged commit 88baa9e into main Nov 7, 2024
1 check passed
@zackgalbreath zackgalbreath deleted the sync_script_all_prechecks branch November 7, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants