[junit] only include stdout in report for failures (elastic#60530)

* [junit] only include stdout in report for failures * fix assertion Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger · Mar 19, 2020 · da7192b · da7192b
1 parent 053da12
commit da7192b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/dev/mocha/__tests__/junit_report_generation.js b/src/dev/mocha/__tests__/junit_report_generation.js
@@ -129,7 +129,7 @@ describe('dev/mocha/junit report generation', () => {
         name: 'SUITE SUB_SUITE never runs',
         'metadata-json': '{}',
       },
-      'system-out': testFail['system-out'],
+      'system-out': ['-- logs are only reported for failed tests --'],
       skipped: [''],
     });
   });

diff --git a/src/dev/mocha/junit_report_generation.js b/src/dev/mocha/junit_report_generation.js
@@ -126,13 +126,15 @@ export function setupJUnitReportGeneration(runner, options = {}) {
 
     [...results, ...skippedResults].forEach(result => {
       const el = addTestcaseEl(result.node);
-      el.ele('system-out').dat(escapeCdata(getSnapshotOfRunnableLogs(result.node) || ''));
 
       if (result.failed) {
+        el.ele('system-out').dat(escapeCdata(getSnapshotOfRunnableLogs(result.node) || ''));
         el.ele('failure').dat(escapeCdata(inspect(result.error)));
         return;
       }
 
+      el.ele('system-out').dat('-- logs are only reported for failed tests --');
+
       if (result.skipped) {
         el.ele('skipped');
       }