Support service version tagging #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for specifying the service version using the `version` tag, based on a span's `service_version`.
gorkunov
force-pushed
the
support-service-version
branch
from
ffb27a0
to
56b51de
Compare
achedeuzot
approved these changes
Jan 9, 2023
|
Hi there @GregMefford @zachdaniel 👋 First of all, thanks for all your work on Spandex ❤️. I'm wanted make a push to have this nice PR merged soon, it would be a big help for us 🙏. Thanks 🙇 |
zachdaniel
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for specifying the service version using the
versiontag, based on a span'sservice_version.Kudos to @kamilkowalski (I just updated it with latest version).
Note: service_version was merged in this spandex PR#122.