-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synapse workers leave "not-found failed" units after removal #1461
Comments
Do you get these errors when you do From what I remember, we are dynamically populating the list of services that need to be started as the playbook executes. If workers are disabled, there should never be a Or is this some error during worker cleanup, not during |
The error is part of workers cleanup process (task "Ensure any worker services are stopped"), so it's |
Thanks for reporting this! While working on the Dendrite support branch (#818), I've encountered this same problem ( Seems like running a bar The Ansible I see a bunch of ( Interestingly, neither Thankfully,
By excluding Let's see how it goes with this fix. If anyone has a better idea, we can revisit this. |
I just want to mention I ran into the same problem, even with the fix applied a few months ago. What helped me is running Maybe other people discovering this thread will find it useful. |
Hello,
when you enable synapse workers and then disable them, even after removal by playbook workers' units' info still exists in systemd and you can see
not-found failed
state if you list services (just runsystemctl
without params to get the full list).That's not a problem itself (even if you google for such behavior you'll find answers like "that's ok"), but when you run playbook again, it will fail with following errors (keep in mind that units were already removed and those services are just "ghosts" without any actual service):
To fix that issue manually, you can run
systemctl reset-failed
, but I think how it can be automated.My first idea was to add following task right under "Ensure any worker services are stopped" task in the
roles/matrix-synapse/tasks/synapse/workers/setup_uninstall.yml
:But it will not work on the first run (because units will not be marked as
not-found failed
at that moment), so it should be actually before the "Ensure any worker services are stopped" to fix the issue, but it will look weird.Sorry, I don't have better idea how to implement it, so here is the solution (the code above) - I hope you will find a correct place to add it
The text was updated successfully, but these errors were encountered: