Upgrade matrix-synapse-shared-secret-auth (1.0.2 -> 2.0) #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spantaleev
added a commit
to devture/matrix-synapse-shared-secret-auth
that referenced
this pull request
Feb 11, 2022
Disabling it can be helpful to work around element-hq/element-web#19605 Related to spantaleev/matrix-docker-ansible-deploy#1374
For now, we disable the new `com.devture.shared_secret_auth` login type by default, because it causes problems with Element: element-hq/element-web#19605 This also becomes the first module to use the new Synapse module system that got introduced in Synapse v1.46.0. Despite these upgrades, things should remain functionally identical as far as bridges, matrix-corporal or other consumers are concerned.
spantaleev
force-pushed
the
shared-secret-auth-v2
branch
from
21efe1c to
5a69c89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to work well (and is backward compatible by default),
but suffers from this issue with Element: element-hq/element-web#19605