Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic fedora support #1614

Merged
merged 3 commits into from
Feb 11, 2022
Merged

add basic fedora support #1614

merged 3 commits into from
Feb 11, 2022

Conversation

Wunderharke
Copy link
Contributor

@Wunderharke Wunderharke commented Feb 9, 2022

7330992 fixed the major_version compare and made Fedora deployments to use setup_redhat8.yml. This however broke the script on fedora as there is no EPEL package. This commit adds very basic fedora support by:

  1. Separates task into own file (for RedHat OS with major version > 30)
  2. removes EPEL task for fedora
  3. replaces docker-ce repo details

Not sure whether docker-py is necessary for fedora.

Wunderharke and others added 3 commits February 9, 2022 16:56
…to use setup_redhat8.yml. This however broke the script on fedora as there is no EPEL package. This commit add very basic fedora support.
@spantaleev spantaleev merged commit fa9b69e into spantaleev:master Feb 11, 2022
@spantaleev
Copy link
Owner

I removed some misleading with_items statements and merged this. Thanks! 👍

If you think the playbook works well on Fedora now, we can also update docs/prerequisites.md and mention it.


Not sure whether docker-py is necessary for fedora.

You can try yum removing it on your system, removing it from roles/matrix-base/tasks/server_base/setup_fedora.yml and re-running the playbook. If nothing breaks, it's likely not necessary (well, or you're not hitting any tasks that require it).

As per the docker_image_module requirements, it seems necessary:

Docker SDK for Python: Please note that the docker-py Python module has been superseded by docker (see here for details). For Python 2.6, docker-py must be used. Otherwise, it is recommended to install the docker Python module. Note that both modules should not be installed at the same time. Also note that when both modules are installed and one of them is uninstalled, the other might no longer function and a reinstall of it is required.

Perhaps using the docker Python module instead of docker-py is better.

I think you may be able to:

  • stop installing python3-pip
  • stop installing docker-py via pip
  • install python3-docker using yum instead

To clean up your installation, you probably need to do pip remove docker-py and dnf remove python3-pip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants