Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maubot moanos #1894

Merged
merged 54 commits into from
Jul 20, 2022
Merged

Maubot moanos #1894

merged 54 commits into from
Jul 20, 2022

Conversation

moan0s
Copy link
Contributor

@moan0s moan0s commented Jun 24, 2022

this PR is mainly based on #622 and for me it was easier copy the work that @Cadair did into my branch.
I tested this role and can successfully install maubot with reverse proxy and configuration options.

The role could be more configurable but I think it is a good start.

If this is something with perspective to be merged I can write up some documentation

@Cadair Cadair mentioned this pull request Jun 24, 2022
3 tasks
Copy link
Owner

@spantaleev spantaleev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up and getting it to work! 🙇

I have some feedback that aims to make it more polished and more consistent with our naming conventions, etc.

roles/matrix-bot-maubot/tasks/setup_install.yml Outdated Show resolved Hide resolved
roles/matrix-bot-maubot/templates/config/config.yaml.j2 Outdated Show resolved Hide resolved
roles/matrix-bot-maubot/templates/config/config.yaml.j2 Outdated Show resolved Hide resolved
roles/matrix-bot-maubot/templates/config/config.yaml.j2 Outdated Show resolved Hide resolved
moan0s and others added 14 commits June 24, 2022 17:36
Co-authored-by: Slavi Pantaleev <slavi@devture.com>
Co-authored-by: Slavi Pantaleev <slavi@devture.com>
No functionality changed
Co-authored-by: Slavi Pantaleev <slavi@devture.com>
The /data is hardcoded in the container
This shall indicate that the public url of maubot is here configured the same as matrix_server_fqn_matrix but this must not be the case.
In the config I used the matrix fqnd directly as this part of the config is directly bound to the homeserver we want to connect to (but can not use the internal)
@spantaleev spantaleev merged commit 1f2d100 into spantaleev:master Jul 20, 2022
spantaleev added a commit that referenced this pull request Jul 20, 2022
spantaleev added a commit that referenced this pull request Jul 20, 2022
Related to #1894

Because the configuration file is now mounted as readonly and maubot tries to update it on start,
we get this warning:
> Failed to create tempfile to write updated config to disk: [Errno 30] Read-only file system: '/config/tmpfa8vcb3y.yaml'

It doesn't seem to cause issues though.

Because the configuration is no longer overwritten on every bot start, each
next Ansible run should no longer overwrite it again and report a
"changed" task.
spantaleev added a commit that referenced this pull request Jul 20, 2022
spantaleev added a commit that referenced this pull request Jul 20, 2022
spantaleev added a commit that referenced this pull request Jul 20, 2022
spantaleev added a commit that referenced this pull request Jul 20, 2022
spantaleev added a commit that referenced this pull request Jul 20, 2022
spantaleev added a commit that referenced this pull request Jul 20, 2022
…ctually make maubot port configurable

Related to #1894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants