feat: add sliding-sync-proxy support #2515
Conversation
| @@ -26,6 +26,11 @@ | |||
| "preferredDomain": {{ matrix_client_element_jitsi_preferredDomain|to_json }} | |||
| } | |||
| {% endif %} | |||
| {% if matrix_sliding_sync_proxy_enabled %}, | |||
| "org.matrix.msc3575.proxy": { | |||
| "url": "https://{{ matrix_server_fqn_sliding_sync_proxy }}/_matrix/client/unstable/org.matrix.msc3575/sync" | |||
There was a problem hiding this comment.
I believe this should not include the path to the sync API, just the URL of sync proxy:
{
"org.matrix.msc3575.proxy": {
"url": "https://{{ matrix_server_fqn_sliding_sync_proxy }}"
}
}See Matrix.org's client well-known as an example:
https://matrix.org/.well-known/matrix/client
There was a problem hiding this comment.
While, I'd generally agree, the way I read the Section in the MSC3575 as it is now, it specifically talks about the URL the sync is to be found at. I've ask there for clarification.
There was a problem hiding this comment.
Hmm, the way I read that section was that both the well-known JSON key: org.matrix.msc3575.proxy and the path to the sync endpoint are prefixed.
One stabilized, the JSON key would just be proxy
There was a problem hiding this comment.
The Proxy is a temporary measure im not sure it will actually become stable. As in its likely there wont be a proxy that is under a stable identifier as this will just become sync v4 endpoint wise
There was a problem hiding this comment.
Clarification from Travis on the matter of the destiny of the proxy. It seems like its not going to become stabilised also as for what the /.well-known content should be to me it sounds like it should be
{
"org.matrix.msc3575.proxy": {
"url": "https://{{ matrix_server_fqn_sliding_sync_proxy }}"
}
}as @Kab1r is suggesting.
|
Because of priority reshuffling I won't be working on this for the next few days yet. If anyone wants to take this and run it to completion, please feel free to do so and superseed my PR. The current state and necessary tasks from my point of view are:
|
This allows people to try out the new Element X clients, which need to run against the sliding-sync proxy (https://github.com/matrix-org/sliding-sync). Supersedes #2515 The code is based on the existing PR (#2515), but heavily reworked. Major changes: - lots of internal refactoring and variable renaming - fixed self-building to support non-amd64 architectures - changed to talk to the homeserver locally, over the container network (not publicly) - no more matrix-nginx-proxy support due to complexity (see below) - no more `matrix_server_fqn_sliding_sync_proxy` in favor of `matrix_sliding_sync_hostname` and `matrix_sliding_sync_path_prefix` - runs on `matrix.DOMAIN/sliding-sync` by default, so it can tried easily without having to create new DNS records
|
Sliding Sync support is here now. Thanks to everyone who contributed to this! |
fixes #2478