-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with mautrix dbs on resource-constrained systems #725
Fix issues with mautrix dbs on resource-constrained systems #725
Conversation
0619322
to
7e1e7da
Compare
Does that network disconnect even do anything when you've removed the container and then force-removed it? It should be completely gone, shouldn't it. Thinking about it now, we can probably run the migrations container without networking ( |
I found that the a |
According to this. It looks like something might fail if the non-matrix docker bridge is used: |
You're right. Some people may be overriding the configuration and pointing it to |
Is this just for telegram or for all mautrix bridges? |
Probably for all bridges (not just mautrix ones). Well, not for now, because none of them use a DB that's on the network. But they should in the future. Especially after #740 and some related work lands. |
I'd rather we don't merge this as it appears to be a hacky workaround for some weird container issue, which is not experienced commonly and may have been been fixed in newer Docker releases (20.10 appeared recently). If you're still experiencing it, let's see how we can reproduce it and come up with a similar fix. Thanks anyway! 👍 |
Hey cool with me! Sorry about the delay (holidays) |
The issue:
Whenever I restart my server or docker daemon, Mautrix-based bridges with alembic databases refuse to start because of this error:
It's because the
--rm
step times-out and the old container can't be removed. For some reason the container can't be removed by the daemon.This fix will first try to kill the database container, then if that times out it forcefully removes the container and the network interface.