-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to multiple authentication #901
base: main
Are you sure you want to change the base?
Conversation
@yomaaf is attempting to deploy a commit to the sparckles Team on Vercel. A member of the Team first needs to authorize it. |
CodSpeed Performance ReportMerging #901 will not alter performanceComparing Summary
Benchmarks breakdown
|
Hey @yomaaf 👋 Thanks for the PR. However, I do not understand the problem you are addressing here. What do you mean by "multiple authentication" and why is it needed in Robyn? |
Hi @sansyrox. "Multiple authentication" refers to the capability of a system to support different methods or mechanisms for verifying the identity of a user. This can include a variety of authentication methods such as:
Why is it needed in Robyn?
Addressing fina-joy's Issue #708
|
Hey @yomaaf 👋 There is only one authentication handler in Robyn so the users can override the implementation. I believe your PR will serve well as a Robyn Plugin like the following - https://robyn.tech/documentation/plugins However, I don't know enough about auth and need some time to think about it. I will get back to you after the weekend 😄 Meanwhile, if you have any items to help me with my research, I'd highly appreciate them. Thanks again for all the hard work :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need this functionality)
6ee78c5
to
0f16260
Compare
Description
This PR fixes #708
Hello @sansyrox. This is a split PR for support for multiple authentication, however it does not include support for subrouter. Because, as previously explained. When decorating is called, it registers the route. So the authentication handler is not registered on the subrouter because the subrouter already register the route before the authentication handler is registered. I'll include support for the subrouter in the nested router PR. But it will require this PR merge first. So check out this PR first.