Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): too long vote choice #399

Merged
merged 8 commits into from
Oct 25, 2023
Merged

fix(ui): too long vote choice #399

merged 8 commits into from
Oct 25, 2023

Conversation

JeukHwang
Copy link
Contributor

it fixes #182

@JeukHwang JeukHwang added bug Something isn't working FE Tasks for the front-end part labels Sep 26, 2023
@JeukHwang JeukHwang self-assigned this Sep 26, 2023
@netlify
Copy link

netlify bot commented Sep 26, 2023 •
edited
Loading

✅ Deploy Preview for biseo-preview ready!

Name Link
🔨 Latest commit 3c9080e
🔍 Latest deploy log https://app.netlify.com/sites/biseo-preview/deploys/653932819f4e920007703082
😎 Deploy Preview https://deploy-preview-399--biseo-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JeukHwang JeukHwang enabled auto-merge September 26, 2023 12:35
@JeukHwang JeukHwang disabled auto-merge September 26, 2023 12:36
@JeukHwang JeukHwang marked this pull request as draft September 26, 2023 12:38
@JeukHwang JeukHwang marked this pull request as ready for review September 26, 2023 12:46
@JeukHwang JeukHwang enabled auto-merge September 26, 2023 12:46
@JeukHwang JeukHwang marked this pull request as draft October 24, 2023 13:11
auto-merge was automatically disabled October 24, 2023 13:11

Pull request was converted to draft

minjoo0729
minjoo0729 reviewed Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@minjoo0729 minjoo0729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로컬에서 확인해보고 싶은데 지금 제 docker가 컨테이너가 바뀐 상태라서 이따 공코 시간에 로컬로 보여줄 수 있나용

client/src/components/molecules/ModalInnerTextBox.tsx Outdated Show resolved Hide resolved
@JeukHwang JeukHwang marked this pull request as ready for review October 25, 2023 12:03
@JeukHwang
Copy link
Contributor Author

solve #170
실수로 둘 다 같은 곳에서 진행했습니다

@JeukHwang JeukHwang linked an issue Oct 25, 2023 that may be closed by this pull request
[Modal UI] 진행중인 투표 - 투표 항목 개수 늘어나면 깨짐 #170
Closed
minjoo0729
minjoo0729 requested changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@minjoo0729 minjoo0729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우선 UI적으로 내일 전에 수정이 필요한 부분이라서 CSS 토큰화는 신경 안쓰고 작업해줘도 될 것 같아요 :)
수고하셨습니당

packages/web/src/components/molecules/ModalInnerTextBox.tsx Outdated Show resolved Hide resolved
packages/web/src/components/molecules/ModalInnerTextBox.tsx Outdated Show resolved Hide resolved
packages/web/src/components/molecules/ModalInnerTextBox.tsx Outdated Show resolved Hide resolved
packages/web/src/components/molecules/ModalInnerTextBox.tsx Outdated Show resolved Hide resolved
packages/web/src/components/molecules/ModalInnerTextBox.tsx Outdated Show resolved Hide resolved
packages/web/src/components/molecules/ModalInnerTextBox.tsx Outdated Show resolved Hide resolved
@JeukHwang
Copy link
Contributor Author

우선 UI적으로 내일 전에 수정이 필요한 부분이라서 CSS 토큰화는 신경 안쓰고 작업해줘도 될 것 같아요 :) 수고하셨습니당

코드리뷰 열심히 해주셔서 감사합니다 :)

@JeukHwang JeukHwang requested a review from minjoo0729 October 25, 2023 15:23
JeukHwang
JeukHwang commented Oct 25, 2023
View reviewed changes
Copy link
Contributor Author

@JeukHwang JeukHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하겠습니다!

minjoo0729
minjoo0729 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@minjoo0729 minjoo0729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
수고하셨습니당

@minjoo0729 minjoo0729 merged commit ea11998 into main Oct 25, 2023
@minjoo0729 minjoo0729 deleted the feat/#182-too-long-vote-choice branch October 25, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minjoo0729 minjoo0729 minjoo0729 approved these changes

@donghyo1234 donghyo1234 Awaiting requested review from donghyo1234

@kjy2844 kjy2844 Awaiting requested review from kjy2844

@prectal123 prectal123 Awaiting requested review from prectal123

Assignees

@JeukHwang JeukHwang

Labels
bug Something isn't working FE Tasks for the front-end part
Projects
None yet
Milestone
No milestone
2 participants
@JeukHwang @minjoo0729