Feat/minor UI updates #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 6, 2024
Closed
✅ Deploy Preview for biseo-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
Closed
Sanghou
reviewed
Mar 13, 2024
| @@ -18,6 +18,7 @@ export const Cell = styled.td<{ w?: Size; scroll?: boolean }>( | |||
| padding: 6px 5px; | |||
| font-size: 10px; | |||
| font-weight: 500; | |||
| line-break: anywhere; | |||
There was a problem hiding this comment.
이거 anywhere인 이유가 있을까요?
Cell이 width가 작아서 줄 바꿈이 자주 일어나는 환경인지?
다른 line-break 스타일 (word 등)과 비교해서 어떤 점을 바탕으로 고르시게 되었나요?
There was a problem hiding this comment.
line-break는 anywhere이 맞을 것 같네요 이슈 #446에 첨부해주신거 보니
There was a problem hiding this comment.
table 칸에 들어가는 요소가 주로 띄어쓰기가 없이 작성되는 이름, 닉네임이라 anywhere로 작성했습니다.
참고로 이슈 #446 은 다른 분이 작업 중이라고 하셔서 (제욱이?) closed issue에 추가하지 않았습니다!
|
@Sanghou PR 올릴 때 실수로 구 이미지를 첨부한 것 같아요! 제가 로컬에서 실행했을 때는 border에 문제가 없어보입니다 🤔 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
It closes #146, #274, and #403.
스크린샷
ModalInnerTextBox내AddVoteOptionArea의 border가 겹쳐진 부분을 수정합니다.PreparingAgendaCard,OngoingAgendaCard,AgendaTemplateCard)이후 Task *
ModalInnerTextBox내 deprecated된Box,BorderedBox,Scroll등을 div로 교체하였습니다. 다른 component에서도 deprecated된 component들을 교체해야 합니다.ModalInnerTextBox내AddVoteOptionArea에서 overflow가 발생할 때 scroll bar 영역만큼 항목 div의 width가 감소합니다. 이를 원래대로 수정해야 합니다.