Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align 'loading' text to center #476

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

Sanghou
Copy link
Collaborator

@Sanghou Sanghou commented Mar 20, 2024

요약 *

It closes #465
따로 피그마에 명시된 디자인이 없어서 중앙 정렬을 하였습니다.

고민 하나 했던건 side margin : auto vs text-align : center인데 직관적인 text-align을 사용했습니다.

스크린샷

개선 후
image

이후 Task *

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for biseo-preview ready!

Name Link
🔨 Latest commit 4d82422
🔍 Latest deploy log https://app.netlify.com/sites/biseo-preview/deploys/65fa8941e79e910008f4698f
😎 Deploy Preview https://deploy-preview-476--biseo-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sanghou Sanghou self-assigned this Mar 20, 2024
Copy link
Member

@yumincho yumincho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Sanghou Sanghou merged commit d2a4cb7 into main Mar 27, 2024
5 checks passed
@Sanghou Sanghou deleted the fix/loading-title-position branch March 27, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants