Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show end time on terminated agenda card #493

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

yumincho
Copy link
Member

@yumincho yumincho commented May 20, 2024

요약 *

It closes #490

  • 유저 모드와 투표 관리에서 Terminated agenda card의 우측 상단에 투표가 종료된 날짜를 표시합니다.
  • 유저 모드에서 카드를 열었을 경우, 카드 하단에서 투표가 종료된 일시를 확인할 수 있습니다.

Notes

  • 투표가 종료되자마자 바로 날짜가 표시되도록 state 업데이트 로직을 수정했습니다. 이 과정에서 admin.agenda.statusUpdated의 api 반환값이 일부 변경되었습니다.

스크린샷

image
image

이후 Task *

  • 없음

Copy link

netlify bot commented May 20, 2024

Deploy Preview for biseo-preview ready!

Name Link
🔨 Latest commit 6079f86
🔍 Latest deploy log https://app.netlify.com/sites/biseo-preview/deploys/664dd48920fe48000875accd
😎 Deploy Preview https://deploy-preview-493--biseo-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yumincho yumincho changed the title Feat/show end time Feat: show end time on terminated agenda card May 20, 2024
@yumincho yumincho changed the title Feat: show end time on terminated agenda card feat: show end time on terminated agenda card May 20, 2024
@yumincho yumincho marked this pull request as ready for review May 20, 2024 15:04
@yumincho yumincho self-assigned this May 22, 2024
@yumincho yumincho force-pushed the feat/show-end-time branch from 487632f to 6079f86 Compare May 22, 2024 11:18
Copy link
Collaborator

@rjsdn0 rjsdn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjsdn0 rjsdn0 merged commit 6b67fd1 into main May 22, 2024
5 checks passed
@rjsdn0 rjsdn0 deleted the feat/show-end-time branch May 22, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

아젠다에 표시되는 시간 endAt으로 교체
2 participants