#114 [bug] Express & Socket.io sessions are not synchronized automatically #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
withSang
changed the title
withSang
deleted the
#114-bug-express-socketio-sessions-are-not-synchronized-automatically
branch
withSang
commented
Aug 21, 2022
| @@ -118,20 +113,24 @@ const ioListeners = (io, socket) => { | |||
| // join chat room | |||
| joinChatRoom({ session: session }, socket.id, roomId); | |||
| socket.join(`chatRoom-${roomId}`); | |||
| // session.save(); // Socket.io 세션의 변경 사항을 Express 세션에 반영. | |||
There was a problem hiding this comment.
@14KGun @GrasshopperBears @ptptsw
으악 제가 여기 주석 처리해놨어요
다시 커밋해야겠어요.. 죄송합니다 ㅠㅠ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It fixes #113
src/route/chats.socket.js에서 Promise constructor에 async 함수가 들어가는 패턴의chatsForRoom함수를 Promise constructor 없이 똑같은 기능을 하도록 수정하였습니다.It fixes #114
Socket.io에서 사용자 session에 chatRoomId 속성을 설정해도 express의 session에 해당 값이 바로 저장되지 않는 문제가 발생하여,
session.save()를 호출하여 명시적으로 Socket.io 세션과 express의 세션을 동기화했습니다.Extra info
Images
Further Work
/static라우터 제거: 서버에서 정적 파일을 호스팅할 필요가 없어졌습니다./rooms,/usersAPI 제거: admin 페이지로 대체 가능합니다. Add: support maxPartLength in /rooms/search #100 (comment)/auth/try여야 하는데 테스트 코드에서는/auth/sparcssso로 적혀 있어서 로그인 성공 여부가 제대로 테스트되지 않는 문제가 발생했습니다. 어제 발생한 [Bug] auth.replace 라우터 새 유저 생성 안됨 #115 도 CI 단계에서 걸렸었어야 했는데 테스트 코드를 잘못 짜서 그러지 못했어요 ㄷ