#159 TypeScript 마이그레이션 #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
12 tasks
kmc7468
reviewed
Nov 26, 2024
| export { default as responseTimeMiddleware } from "./responseTime"; | ||
| export { default as sessionMiddleware } from "./session"; | ||
| export { default as validatorMiddleware } from "./validator"; | ||
| export * from "./zod"; |
kmc7468
reviewed
Nov 26, 2024
|
|
||
| axios | ||
| .post(slackUrl.report, data, config) | ||
| .then((res) => { | ||
| .then(() => { | ||
| logger.info("Slack webhook sent successfully"); | ||
| }) | ||
| .catch((err) => { | ||
| logger.error("Fail to send slack webhook", err); |
There was a problem hiding this comment.
이거 logger는 이렇게 쓰면 안되는걸로 아는데.. 확인 필요합니다
…cs-kaist/taxi-back into #159-add-typescript-support
kmc7468
reviewed
Nov 26, 2024
| try { | ||
| const newNickname = req.body.nickname; | ||
| const newNickname = req.body.nickname; // TODO: Typing |
| @@ -1,103 +1,123 @@ | |||
| const { userModel, banModel } = require("../modules/stores/mongo"); | |||
There was a problem hiding this comment.
Convention 제안: @를 너무 막 쓰고 있는 듯 싶은데, @의 경우 .. 으로 상위 디렉토리(파일)를 참조하는 경우에는 @ 사용을 권장하고, 하위 디렉토리(파일) 및 현재 디렉토리(파일)를 참조할 경우 ./ 사용을 권장함.
There was a problem hiding this comment.
좋은 생각인 것 같습니다! 다음주 마지막 회의에서 논의하고 결정해봐요
TaehyeonPark
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #159
타입스크립트 지원을 추가합니다.
Extra info
To be confirmed
Images or Screenshots
To be confirmed
Further Work