#436 taxi-sample-generator 병합 #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14KGun
reviewed
Nov 27, 2023
|
앗 tools 쪽 수정을 까먹고 안했네요! 금방 수정하겠읍니다 ㅜ |
|
DB 덤프는 잘 되는 것 같은데, 복원이 잘 안되는 것 같습니다. 혹시 원인이 뭘까요? ㅠㅠ 오류가 뜨는 것도 아니고.. mongodb에 db도 생성되는데 collection들에 데이터가 안들어 있네요. |
|
해결했습니다! dump 대신 dump/taxi를 인수로 넘겨주니 잘 작동합니다. |
14KGun
reviewed
Jan 10, 2024
sampleGenerator
Outdated
| @@ -13,7 +13,7 @@ | |||
| "serve": "cross-env TZ='Asia/Seoul' NODE_ENV=production node app.js", | |||
| "runscript": "cross-env TZ='Asia/Seoul' NODE_ENV=production node", | |||
| "lint": "npx eslint --fix .", | |||
| "sample": "cd sampleGenerator && npm start && cd .." | |||
| "sample": "cd src/sampleGenerator && npm start && cd .." | |||
There was a problem hiding this comment.
이런식으로 samplegenerator 스크립트 실행시켜도 좋을 것 같네요
There was a problem hiding this comment.
pnpm -F taxisamplegenerator 로 시도해 봤는데 안되네요! ㅜㅜ
chlehdwon
requested changes
Jan 11, 2024
| profileImageUrl: generateProfileImageUrl(), | ||
| joinat: Date.now(), | ||
| subinfo: { | ||
| kaist: new String(20230000 + num), // ^-^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #436
taxi-sample-generator를 taxi-back에 머지하였습니다.
기존 taxi-sample-generator 레포에 남겨진 커밋 로그도 taxi-back에 모두 합쳐졌습니다. (GitHub에선 안보이지만, git blame과 git log를 통해 확인할 수 있어요.)
Further Work