Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#135.9 auth.replace API에 swagger 적용 #458

Merged
merged 6 commits into from
Feb 15, 2024
Merged

#135.9 auth.replace API에 swagger 적용 #458

merged 6 commits into from
Feb 15, 2024

Conversation

chlehdwon
Copy link
Contributor

@chlehdwon chlehdwon commented Feb 12, 2024 •
edited
Loading

Summary

It closes #135

Extra info

  • auth.replace에 대한 문서화를 진행하였습니다.
  • 아래처럼 auth tag에 route는 auth(dev)로 표시되어 실질적으로 사용은 못하도록 막아놓았습니다.
  • 또한, swagger schema 정의를 /docs 폴더 안에 /schemas로 관리하도록 파일 구조를 정리하였습니다.

Images or Screenshots

image
image

Further Work

  • Zod 검토 관련 조사

@chlehdwon chlehdwon added the documentation Improvements or additions to documentation label Feb 12, 2024
@chlehdwon chlehdwon self-assigned this Feb 12, 2024
@chlehdwon chlehdwon requested review from 14KGun, withSang and kmc7468 and removed request for 14KGun February 12, 2024 15:39
withSang
withSang approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

회의 결과 빠르게 반영해주셔서 감사드립니다!! 고생하셨습니다!
감사합니다 :)

@chlehdwon chlehdwon changed the title auth.replace API에 swagger 적용 #135.9 auth.replace API에 swagger 적용 Feb 13, 2024
kmc7468
kmc7468 requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! comment 확인 부탁드려용

src/services/auth.replace.js Outdated Show resolved Hide resolved
src/routes/docs/auth.replace.js Outdated Show resolved Hide resolved
src/routes/docs/auth.replace.js Outdated Show resolved Hide resolved
@chlehdwon chlehdwon requested a review from kmc7468 February 15, 2024 15:22
kmc7468
kmc7468 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르게 반영해 주셔서 감사드립니다! LGTM!

@chlehdwon chlehdwon merged commit e8ddfaf into dev Feb 15, 2024
1 check passed
@chlehdwon chlehdwon deleted the #135.9-docs-auth.replace branch February 15, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@withSang withSang withSang approved these changes

@kmc7468 kmc7468 kmc7468 approved these changes

@14KGun 14KGun Awaiting requested review from 14KGun

Assignees

@chlehdwon chlehdwon

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API 검수
3 participants
@chlehdwon @kmc7468 @withSang