#457 추천인 시스템 구현 #470
Merged
#457 추천인 시스템 구현 #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
|
5회마다 eventSharing5 퀘스트가 달성되는 것도 테스트 완료되었습니다. 아래 이미지를 참고해 주세요.
|
kmc7468
commented
Feb 20, 2024
| @@ -154,6 +154,7 @@ const completeQuest = async (userId, timestamp, quest) => { | |||
| logger.info(`User ${userId} successfully completed ${quest.id}Quest`); | |||
| return { | |||
| quest, | |||
| questCount: questCount + 1, | |||
There was a problem hiding this comment.
사실 조금 위험한 코드이긴한데, MongoDB에 트랜잭션을 도입하여 퀘스트 달성에 필요한 7단계의 작업을 Atomic하게 처리하지 않으면 완벽하게 해결할 방법이 딱히 없는 것 같습니다.
왜 위험한 코드라고 판단했냐면, 혹시라도 같은 유저가 같은 퀘스트를 달성하고자 하는 요청이 동시에 여러 번 들어오게 되면, await 때문에 7단계가 쪼개어져 처리되면서 questCount 값이 부정확하게 될 수도 있기 때문입니다. 물론 발생 가능성이 매~우 낮은 시나리오이긴 합니다..
|
리뷰 요청 드린 분들 다들 바쁘신 것 같아서 바로 머지하겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #457
추천인 시스템을 구현하기 위해, 초대 링크 관련 API를 구현합니다.
Further Work