bug fix: temp. sensor value is divided by 256. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… do bit shift by 4 not 8 to divide by 16.
|
Thank you for the contribution! We have been having difficulty with the temperature readings on the LSM9DS1. The current code is broken as it outputs large negative values; however, I am still getting an output of -71 (at room temp) with your suggestion. Is this what you are getting? |
|
I don't own the LSM9DS1 board. I was helping a friend with some diagnostics and I found this which I'm sure is wrong so I fixed it. I didn't saw any other obvious bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temp. Sensor sensitivity is 16 LSB/C we want to divide by 16 which means bitshift by 4 not 8.
Value is 11bit, padded to 16bit with a sign bit, so I guess this is what created the confusion.