Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

#5 only set I2C_BUFFER_LENGTH if not already defined #7

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

trycoon
Copy link

@trycoon trycoon commented Apr 7, 2019

only set I2C_BUFFER_LENGTH if not already defined, this fixes compile warnings on ESP32:

Compiling .pioenvs/nodemcuv2/lib3cb/SparkFun Ublox Arduino Library_ID5746/SparkFun_Ublox_Arduino_Library.cpp.o
In file included from .piolibdeps/SparkFun Ublox Arduino Library_ID5746/src/SparkFun_Ublox_Arduino_Library.cpp:29:0:
.piolibdeps/SparkFun Ublox Arduino Library_ID5746/src/SparkFun_Ublox_Arduino_Library.h:71:0: warning: "I2C_BUFFER_LENGTH" redefined
#define I2C_BUFFER_LENGTH 32
^
In file included from .piolibdeps/SparkFun Ublox Arduino Library_ID5746/src/SparkFun_Ublox_Arduino_Library.h:38:0,
from .piolibdeps/SparkFun Ublox Arduino Library_ID5746/src/SparkFun_Ublox_Arduino_Library.cpp:29:
/home/trycoon/.platformio/packages/framework-arduinoespressif32/libraries/Wire/src/Wire.h:34:0: note: this is the location of the previous definition
#define I2C_BUFFER_LENGTH 128

@trycoon trycoon mentioned this pull request Apr 7, 2019
@nseidle nseidle merged commit 2c7fcd2 into sparkfun:master Apr 8, 2019
@nseidle
Copy link
Member

nseidle commented Apr 8, 2019

Excellent. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants