Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SPUURLRequest #2124

Closed
zorgiepoo opened this issue May 9, 2022 · 0 comments · Fixed by #2134
Closed

Remove SPUURLRequest #2124

zorgiepoo opened this issue May 9, 2022 · 0 comments · Fixed by #2134
Milestone
2.2

Comments

@zorgiepoo
Copy link
Member

zorgiepoo commented May 9, 2022 •
edited
Loading

Remove SPUURLRequest wrapper. It was added because older OS's (around 10.8) didn't support NSSecureCoding on NSURLRequest. Need to test the properties we care about are still preserved through archiving/unarchiving and test behavior on older OS's before removing the wrapper. Removing this would allow better mutation of download requests.
@zorgiepoo zorgiepoo added this to the 2.2 milestone May 9, 2022
@zorgiepoo zorgiepoo mentioned this issue Jun 4, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

Remove SPUURLRequest class sparkle-project/Sparkle
1 participant
@zorgiepoo