fix: undesirable popups when checking for updates

[lwouis]

Hi!

I use this page for release notes. It contains some JavaScript to load google translate if the user language is not English. This works great in a WebView, however it creates 3 popups:

After digging deeper, I found out that the google translate script loads a bunch of iframes. These have no src attribute. They triggers the decidePolicyForNavigationAction method in Sparkle, which calls [[NSWorkspace sharedWorkspace] openURL:requestURL]; which result in the popups.

I don't think there is any point in ever opening a about:blank link for the user, thus this PR ignores these URLs.

---

If you decide to not merge this, could you please help me build on my fork? I ran make release, then made a zip out of the result, uploaded it to my fork's releases, then made these changes to the podspec. Also note that I had to do that tweak to build on my mac.

After this I updated the Podfile in my project to: pod 'Sparkle', :git => 'https://github.com/lwouis/Sparkle.git', :branch => 'master'.

My project doesn't build and complains that the Sparkle framework is missing. I don't quite understand how Sparkle is packaged/delivered.

Thanks a lot!

Louis Pontoise

[kornelski]

Good catch. Thank you

[lwouis]

Hi @kornelski! Thanks for merging the PR!

Do you know how i can get this in my project? I tried really hard to point to master on my fork, but for some reason it doesn't grab the .zip file in my fork releases. Which I built locally on my machine, and uploaded to my fork releases.

I think i'll have the same issue if i point to the main repo master branch because here there is not even a release zip for master i believe.

Are you going to release the next 1.x version soon perhaps? Otherwise i need to be able to point to my fork somehow, but i don't know how to. It just doesn't want to download the zip from my fork even if i remove all the caches in cocoapods. I updated the .podspec file properly I believe, but something is wrong still.

[kornelski]

I've made an alpha release on github

[lwouis]

Hi @kornelski! Thanks for the release! I'm not sure how to use it though.

• It doesn't seem to be released on Cocoapods.
• I can't point to master because the .podspec is referencing 1.23.0

How could I use this new alpha release in my project?

[kornelski]

No, it's not in cocoapods. You can add framework to your project directly, as explained in docs.

[lwouis]

I'm sorry to ask again 🙇‍♂️, but I would really like to avoid ejecting from using cocoapods as I'm doing today. Could you have a quick look at this diff? It's only a few lines. This is what I did when I forked, built Sparkle and locally, and uploaded it on the fork's releases. Is this not enough? What step am I missing to be able to import the project using cocoapods? It think I must be very close and only missing a small step.

[kornelski]

That looks ok to me. But I've never actually used cocoapods.

[lwouis]

For anyone else that may be struggling in the future, I'm sharing what I did here as the documentation is poor on cocoapods. Here is what I did to get the fix on my project while keeping cocoapods as it was.

• I forked Sparkle
• I added a commit with the fix I need, and another commit to update the .podspec and bump sparkle version number
• I ran make release from the project root
• I manually uploaded the resulting archive on the fork's github releases
• I put this in my Podfile:

pod 'Sparkle', :podspec => 'https://raw.githubusercontent.com/lwouis/Sparkle/master/Sparkle.podspec'

You can't point to the repo using :git. It will ignore the :source directive in the .podspec. you have to point to the .podspec directly. None of this is intuitive or properly documented, so I thought I would share.

Also note that for Google Translate to work, I had to amend the commit I shared in this PR. Maybe Google updated their service or something, because I needed a tweek 1 week later, which is visible in the commit I listed above.

Cheers 👍