Change XPC Service product names to be more human readable

[zorgiepoo]

The XPC Service names should not be bundle IDs because they may surface up in the UI.

Particularly, the Installer XPC Service may show up in the authorization prompt when authorization is required to install an update.

This will need an accompanying documentation PR change, and a notice that these services changed to whoever may be using custom scripts that process these services.

I doubt the AuthorizationRef APIs allow customizing this name that shows up (if it did, I would use the original app name). And last I tested, the CFBundleName and CFBundleDisplayName keys didn't affect the name shown here. Apparently the app's name only shows up on Monterey and not previous macOS releases like Big Sur.

Before:

After:

Fixes #2095

Misc Checklist:

• My change requires a documentation update on Sparkle's website repository
• My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

• Sparkle Test App
• Unit Tests
• My own app
• Other (please specify)

After the app is launched and before an update check is made I run:

sudo chown root <my-app-path>

Tested the authorization dialog shows "Installer" instead of "org.sparkle-project.InstallerLauncher" by default.
Tested app upgrading to new Sparkle version works
Tested that non-sandbox app still uses the original app's name.

macOS version tested: 12.1 (21C52)

[zorgiepoo]

Hm for a non-sandbox app, it does use CFBundleName .. It doesn't do that for XPC Services in my testing.

[zorgiepoo]

I'll leave this here a bit to make sure there aren't any better solutions or if anyone has any insights. cc @DivineDominion @tonyarnold @danielpunkass

[DivineDominion]

@zorgiepoo I noticed these titles in some apps, too -- thanks for figuring out where they come from.

So for the optimal readable title, one would

• not need to change anything for non-Sandboxed apps b/c they use the app title anyway
• maybe change "Installer" to e.g. "MyAppName Installer" to disambiguate for Sandboxed apps?

[danielpunkass]

@DivineDominion If I understand the challenge right, the host app's name can't be systematically swapped in at runtime, so to have the "MyAppName Installer" solution it would have to be done as a packaging process by the host app's own build process. I have done some similar trickerey in my own apps to rename helpers to customize them for the host app.

[zorgiepoo]

Right I can’t figure out (or haven’t looked deep enough) on how to dynamically set the name. So there is a config variable to change it if any developer wants to go through the trouble of doing that, to build their own Sparkle.