Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alert activation improvements #2100

Merged
merged 6 commits into from
Mar 7, 2022
Merged

Conversation

zorgiepoo
Copy link
Member

  • Don't activate app when bringing up update alert errors
  • Don't set status window level to floating
  • Add minimize option to status window after checking for updates (i.e, downloading / installing)
  • Allow install button to have focus when app has just launched for scheduled updates within a small threshold (1.5 sec)
  • Reset install button focus when app becomes active again for scheduled updates

Fixes #1008
Related to #924

Misc Checklist:

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested scheduled updates in regular and backgrounded/dockless apps, at launch and non-launch scheduled times.
Tested bringing app back in background from scheduled updates after it's been running for some time.
Tested status window is not floating for deckless app and is now minimizable.

macOS version tested: 12.1 (21C52)

App activation already happens when checking for updates beforehand. Errors ant no new update found errors should not require another app re-activation.
If the status window is left alone, the application will install the update on quit. So having this window forever steal focus is not necessary.
@zorgiepoo zorgiepoo added this to the 2.2 milestone Mar 7, 2022
@zorgiepoo zorgiepoo merged commit f250bea into 2.x Mar 7, 2022
@zorgiepoo zorgiepoo deleted the activation-improvements branch March 7, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add minimize button to SUStatus window after checking for updates
1 participant