Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete fallbacks folder older OS versions #2110

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

Eitot
Copy link
Contributor

@Eitot Eitot commented Apr 16, 2022

This removes two of three fallbacks, which are obsolete.

Misc Checklist:

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

macOS version tested: 12.3.1 (21E258)

@zorgiepoo
Copy link
Member

Thanks. On the topic of future compatibility checks we have, we can remove:

  • All of our __MAC_OS_X_VERSION_MAX_ALLOWED checks (except in SPUXarDeltaArchive which is recent)
  • -[SUOperatingSystem isOperatingSystemAtLeastVersion:] and replace SULog.m usage with using @available() instead.

@zorgiepoo zorgiepoo merged commit c0cf32c into sparkle-project:2.x Apr 22, 2022
@zorgiepoo zorgiepoo added this to the 2.2 milestone Apr 22, 2022
@Eitot Eitot deleted the obsolete-fallbacks branch April 22, 2022 10:09
@Eitot Eitot mentioned this pull request Apr 23, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants