-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standard user driver APIs for gentle scheduled update reminders #2122
Conversation
|
If the user moves the update alert window to somewhere off-center in the screen, we should show the status window (for downloading, extraction, installing progress) in the center where the update alert window was.
Also show update alert in background for active background apps.
This allows developers to provide gentle reminders when scheduled update alerts would normally appear.
This is work a part of #924.
Documentation page written in sparkle-project/sparkle-project.github.io#138
Backgrounded apps no longer steal focus from other active applications when scheduled update alerts show up (unless the app just launched by the user). The update alert window is also not floating above all other app's windows anymore too. A logging message is done for backgrounded apps that schedule update checks but do not implement gentle reminder support.
The progress window (showing downloading, installing) frame position is also now in center to where the update alert window was last placed before being closed, and does not steal focus if the update alert wasn't key.
Foreground apps now wait until the app becomes re-activated before presenting a new update when opting into Sparkle handling showing the update.
APIs are now provided to allow developers to override Sparkle handling of showing updates, or add and dismiss gentle reminders both for foreground and background running applications.
Misc Checklist:
Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
Tested the samples in the documentation PR, while the app is a regular one and a background running one, app scheduled a check near launch and 10 seconds later, while the app was in-active and active (currently frontmost), and while the system has been idle vs has been in active use for non-background running app.
macOS version tested: 12.3 (21E230)