Update last update check time when choosing to install update #2136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the UI driver, this is when the user chooses to Install & Relaunch.
In the automatic download based driver, this is when Sparkle hands off responsibility to its delegate to install the update and they trigger the callback to relaunch the app.
This defers checking for updates on next relaunch too quick when an update was just installed. This matters if there is a long delay between the user being presented an update and them actually installing it, for example.
Fixes #2135
Misc Checklist:
Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
Tested that test app updated and last check update time in user defaults got updated.
Probe update check works from sparkle-cli (when new update is available and isn't available).
Tested that automatic update driver updates last check date when delegate calls block to install/relaunch app, using Test App.
macOS version tested: 12.4 (21F79)