Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update last update check time when choosing to install update #2136

Merged
merged 3 commits into from
Jun 5, 2022

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Jun 4, 2022

In the UI driver, this is when the user chooses to Install & Relaunch.

In the automatic download based driver, this is when Sparkle hands off responsibility to its delegate to install the update and they trigger the callback to relaunch the app.

This defers checking for updates on next relaunch too quick when an update was just installed. This matters if there is a long delay between the user being presented an update and them actually installing it, for example.

Fixes #2135

Misc Checklist:

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested that test app updated and last check update time in user defaults got updated.
Probe update check works from sparkle-cli (when new update is available and isn't available).
Tested that automatic update driver updates last check date when delegate calls block to install/relaunch app, using Test App.

macOS version tested: 12.4 (21F79)

In the UI driver, this is when the user chooses to Install & Relaunch.

In the automatic download based driver, this is when Sparkle hands off responsibility to its delegate to install the update and they trigger the callback to relaunch the app.
@zorgiepoo zorgiepoo merged commit 9ba7352 into 2.x Jun 5, 2022
@zorgiepoo zorgiepoo deleted the update-last-check-time-install branch June 5, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update last update check time before installing update in UI driver
1 participant