Validate permission bits of Sparkle executable for delta updates #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades our a preflight test to see if delta updates are eligible before downloading them. Testing the underlying file system name is not reliable and technically inferior.
Disable it by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades our preflight test of validating that we can perform delta updates before downloading them. Checking the underlying file system type is not reliable and does not cover cases where a 'tainted' bundle moves across file systems.
We also prevent creating new binary delta updates that have an invalid permission mode for Sparkle's executable.
Fixes #2148
Misc Checklist
Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
Tested delta update works with test app (setting env test mode), sparkle-cli works in success and failure (bad permission mode) case of updating an app with delta update provided, added unit tests for creating delta updates, tested manually creating delta updates in success and failure cases. Tested update on actual (Ex)FAT volume on Ventura.
macOS version tested: 12.4 (21F79), 13.0 Beta (22A5266r)