Don't clean up update directory when Autoupdate receives SIGTERM #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under rare circumstances, if Autoupdate receives SIGTERM while the installer queue is installing an update this could cause potential corruption.
SIGTERM is still needed for the daemon/agent to exit gracefully.
zorgiepoo
added a commit
that referenced
this pull request
Dec 20, 2023
Under rare circumstances, if Autoupdate receives SIGTERM while the installer queue is installing an update this could cause potential corruption.
zorgiepoo
added a commit
that referenced
this pull request
May 13, 2024
Under rare circumstances, if Autoupdate receives SIGTERM while the installer queue is installing an update this could cause potential corruption. This is a port of #2479 to 2.2.x branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under rare circumstances, if Autoupdate receives SIGTERM (like during system shutdown) while the installer queue is installing an update this could cause potential corruption.
Fixes #2478
Misc Checklist
Testing
I tested and verified my change by using one or multiple of these methods:
Cannot reproduce actual corruption issue without inserting sleep() calls at specific points + sending a quit event to Autoupdate as the timing window is hard to target / rare. The change here is removing cleanup code that was not necessary (because old items get cleared out the next time an update is installed).
Tested Autoupdate can still be terminated gracefully via SIGTERM.
macOS version tested: 14.1.2 (23B92)