Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback in case SULocalizedStringFromTableInBundle() fails #2533

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Mar 28, 2024

SULocalizedStringFromTableInBundle() should only fail in the abnormal situation where the app bundle may have been moved while it was running. Technically the app is running in an unsupported state but I suppose we can guard against it here.

This is a continuation of #2527 and fixes #2524

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested test app works and works with another language still.

macOS version tested: 14.4 (23E214)

SULocalizedStringFromTableInBundle() should only fail in the abnormal situation where the app bundle may have been moved while it was running. Technically the app is running in an unsupported state but I suppose we can guard against it here.
@zorgiepoo zorgiepoo added this to the 2.6.1 milestone Mar 28, 2024
@zorgiepoo zorgiepoo mentioned this pull request Mar 28, 2024
6 tasks
@zorgiepoo zorgiepoo merged commit 2b7615f into 2.x Mar 29, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the guard-localization branch March 29, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught exception @ SPUNoUpdateFoundRecoverySuggestion()
1 participant