Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and use temp extraction directory in generate_appcast again #2555

Merged
merged 3 commits into from
May 4, 2024

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented May 3, 2024

Fixes #2554

This restores how the code used to work in 2.6.0 except we don't create a link to the archive file, and remove the temp directory before starting. I had removed too much of the prior code in 2.6.1 which included creating the extraction directory in generate_appcast.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested generate_appcast on unarchiving:

  • DMG file
  • tar.* file
  • zip file

macOS version tested: 14.4.1 (23E224)

@zorgiepoo zorgiepoo changed the title Create extraction directory in generate_appcast if it doesn't exist Create and use temp extraction directory in generate_appcast again May 4, 2024
@zorgiepoo zorgiepoo merged commit 946c583 into 2.x May 4, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the generate-appcast-create-extract-directory branch May 4, 2024 04:21
@zorgiepoo zorgiepoo added this to the 2.6.2 milestone May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sparkle 2.6.1 generate_appcast fails with "Could not unarchive"
1 participant