fix: be explicit about frozen string literals to quash warnings

sparklemotion · Mar 24, 2024 · d0676f4 · d0676f4
1 parent cffe324
commit d0676f4
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 6 deletions.
diff --git a/lib/http/cookie.rb b/lib/http/cookie.rb
@@ -1,4 +1,5 @@
 # :markup: markdown
+# frozen_string_literal: true
 require 'http/cookie/version'
 require 'http/cookie/uri_parser'
 require 'time'
@@ -425,7 +426,7 @@ def domain= domain
   # Returns the domain, with a dot prefixed only if the domain flag is
   # on.
   def dot_domain
-    @for_domain ? '.' << @domain : @domain
+    @for_domain ? (+'.') << @domain : @domain
   end
 
   # Returns the domain attribute value as a DomainName object.

diff --git a/lib/http/cookie/scanner.rb b/lib/http/cookie/scanner.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'http/cookie'
 require 'strscan'
 require 'time'
@@ -23,7 +24,7 @@ def initialize(string, logger = nil)
   class << self
     def quote(s)
       return s unless s.match(RE_BAD_CHAR)
-      '"' << s.gsub(/([\\"])/, "\\\\\\1") << '"'
+      (+'"') << s.gsub(/([\\"])/, "\\\\\\1") << '"'
     end
   end
 
@@ -32,7 +33,7 @@ def skip_wsp
   end
 
   def scan_dquoted
-    ''.tap { |s|
+    (+'').tap { |s|
       case
       when skip(/"/)
         break
@@ -51,7 +52,7 @@ def scan_name
   end
 
   def scan_value(comma_as_separator = false)
-    ''.tap { |s|
+    (+'').tap { |s|
       case
       when scan(/[^,;"]+/)
         s << matched

diff --git a/test/helper.rb b/test/helper.rb
@@ -7,7 +7,7 @@ module Test
   module Unit
     module Assertions
       def assert_warn(pattern, message = nil, &block)
-        class << (output = "")
+        class << (output = +"")
           alias write <<
         end
         stderr, $stderr = $stderr, output

diff --git a/test/test_http_cookie.rb b/test/test_http_cookie.rb
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: false
 require File.expand_path('helper', File.dirname(__FILE__))
 require 'psych' if !defined?(YAML) && RUBY_VERSION == "1.9.2"
 require 'yaml'
@@ -757,7 +758,7 @@ def test_max_age=
     assert_equal 12, cookie.max_age
 
     cookie.max_age = -3
-    assert_equal -3, cookie.max_age
+    assert_equal(-3, cookie.max_age)
   end
 
   def test_session

diff --git a/test/test_http_cookie_jar.rb b/test/test_http_cookie_jar.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: false
 require File.expand_path('helper', File.dirname(__FILE__))
 require 'tmpdir'