Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error formatting bug in HTTP::CookieJar::AbstractStore #42

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Fix error formatting bug in HTTP::CookieJar::AbstractStore #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44374a7
Fix an error formatting bug
andrelaszlo Feb 13, 2023
e7f2eb2
Add unit test
andrelaszlo Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/http/cookie_jar/abstract_store.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def implementation(symbol)
require 'http/cookie_jar/%s_store' % symbol
@@class_map.fetch(symbol)
rescue LoadError, IndexError => e
raise IndexError, 'cookie store unavailable: %s, error: %s' % symbol.inspect, e.message
raise IndexError, 'cookie store unavailable: %s, error: %s' % [symbol.inspect, e.message]
end
end

Expand Down
9 changes: 9 additions & 0 deletions test/test_http_cookie_jar.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@ def test_nonexistent_store
}
end

def test_nonexistent_store_in_config
assert_raise_with_message(
ArgumentError,
/cookie store unavailable: :nonexistent, error: cannot load .*nonexistent_store/
) {
HTTP::CookieJar.new(store: :nonexistent)
}
end

def test_erroneous_store
Dir.mktmpdir { |dir|
Dir.mkdir(File.join(dir, 'http'))
Expand Down