-
-
Notifications
You must be signed in to change notification settings - Fork 897
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
instead of using a patched fork of apache c14n from 2013 This commit removes the block parameter from the JRuby API, because a) it didn't previously work the same as CRuby/libxml2 (see earlier commit that introduces block test coverage that failed) b) with the mainline c14n library we can't hack it to support even the broken callback semantics and would be forced to implement something complicated ourselves Given I'm not confident that C14n is widely-used anyway, removing a misfeature like this doesn't seem like a controversial decision. So, questions to the JRuby contributors: Q1: Are we OK with all these new dependencies getting pulled in? Q2: There's some Log4J warning messages being emitted at runtime that I'm not sure whether or how to quash. Any ideas?
- Loading branch information
1 parent
a6f4b3f
commit 6049c5b
Showing
40 changed files
with
58 additions
and
5,431 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.