Skip to content

Commit

Permalink
JRuby gem spec no longer needs to include 1.9
Browse files Browse the repository at this point in the history
because we're officially removing support for JRuby 1.7

Part of #1741

[skip ci]
  • Loading branch information
flavorjones committed Dec 20, 2018
1 parent 1edf503 commit 616a8d1
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -144,17 +144,10 @@ HOE = Hoe.spec 'nokogiri' do
["concourse", "~> 0.15"],
]

if java?
self.spec_extras = {
:platform => 'java',
:required_ruby_version => '>= 1.9.3' # JRuby >= 1.7
}
else
self.spec_extras = {
:extensions => ["ext/nokogiri/extconf.rb"],
:required_ruby_version => '>= 2.1.0'
}
end
self.spec_extras = {
:extensions => ["ext/nokogiri/extconf.rb"],
:required_ruby_version => '>= 2.1.0'
}

self.testlib = :minitest
end
Expand Down

1 comment on commit 616a8d1

@kares
Copy link
Contributor

@kares kares commented on 616a8d1 Jan 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that this hasn't caused issues with JRuby - since there's no ext to build (only on C).
guess rake and the ext logic is smart enough no to build if the declared ext file is actually missing ... (#1714)

Please sign in to comment.