Skip to content

Commit

Permalink
ci(jruby): skip new failing test for #2115
Browse files Browse the repository at this point in the history
and also raise a better-formatted exception in that case
  • Loading branch information
flavorjones committed Nov 27, 2020
1 parent 33d766c commit b1a7986
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ext/java/nokogiri/XmlRelaxng.java
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ private Schema getSchema(Source source, ThreadContext context) {
throw context.getRuntime()
.newRuntimeError("Could not parse document: "+ex.getMessage());
} catch (IOException ex) {
throw context.getRuntime().newIOError(ex.getMessage());
throw context.getRuntime().newIOError(ex.getClass() + ": " + ex.getMessage());
}
}

Expand Down
2 changes: 2 additions & 0 deletions test/xml/test_relax_ng.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ def test_from_document_with_parse_options
end

def test_read_memory_with_parse_options
skip("https://github.com/sparklemotion/nokogiri/issues/2115") if Nokogiri.jruby?

schema = Nokogiri::XML::RelaxNG.read_memory(File.read(ADDRESS_SCHEMA_FILE))
assert_equal Nokogiri::XML::ParseOptions::DEFAULT_SCHEMA, schema.parse_options

Expand Down

0 comments on commit b1a7986

Please sign in to comment.