Skip to content

Commit

Permalink
dep: bump libxml2 min required version to v2.9.2 (#3303)
Browse files Browse the repository at this point in the history
**What problem is this PR intended to solve?**

I'm deciding to drop support for earlier versions because:

- 2.7.7 nanohttp.c doesn't compile on modern systems
- 2.8.0 doesn't have PARSE_BIG_LINES, GNOME/libxml2@968a03a2 introduced
it in 2.9.0
- 2.9.0 and 2.9.1 have the xpath optimization bug that ruined our CSS
queries in :first-child broken with libxml 2.9.0 #829,
GNOME/libxml2@b4bcba23 fixed it in 2.9.2

Also, bump the min recommended version to v2.12.0 because Nick has fixed
a lot of long-standing issues upstream. ♥ ♥ ♥

Followup to #3232
Closes #3287


**Have you included adequate test coverage?**

Existing coverage is sufficient.


**Does this change affect the behavior of either the C or the Java
implementations?**

No.
  • Loading branch information
flavorjones committed Aug 7, 2024
2 parents 084b37e + 3bd6202 commit fda0346
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Nokogiri follows [Semantic Versioning](https://semver.org/), please see the [REA

* [CRuby] Vendored libxml2 is updated to [v2.13.3](https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.13.3). [#3230] @flavorjones
* [CRuby] Vendored libxslt is updated to [v1.1.42](https://gitlab.gnome.org/GNOME/libxslt/-/releases/v1.1.42). [#3230] @flavorjones
* [CRuby] Minimum supported version of libxml2 raised to v2.7.7 (released 2010-03-15) from v2.6.21. [#3232] @flavorjones
* [CRuby] Minimum supported version of libxml2 raised to v2.9.2 (released 2014-10-16) from v2.6.21. [#3232, #3287] @flavorjones
* [JRuby] Minimum supported versino of Java raised to 8 (released 2014-03-18) from 7. [#3134] @flavorjones
* [CRuby] Update to rake-compiler-dock v1.5.1 for building precompiled native gems. [#3216] @flavorjones

Expand Down
4 changes: 2 additions & 2 deletions ext/nokogiri/extconf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

# helpful constants
PACKAGE_ROOT_DIR = File.expand_path(File.join(File.dirname(__FILE__), "..", ".."))
REQUIRED_LIBXML_VERSION = "2.7.7"
RECOMMENDED_LIBXML_VERSION = "2.9.3"
REQUIRED_LIBXML_VERSION = "2.9.2"
RECOMMENDED_LIBXML_VERSION = "2.12.0"

REQUIRED_MINI_PORTILE_VERSION = "~> 2.8.2" # keep this version in sync with the one in the gemspec
REQUIRED_PKG_CONFIG_VERSION = "~> 1.1"
Expand Down

0 comments on commit fda0346

Please sign in to comment.