Feature Request: Option to Treat noscript Tags as Script Enabled
#3178
Comments
|
@taisehub Thanks for opening this issue. We'll look into it! |
|
@stevecheckoway Any thoughts on whether this is a good idea and/or how challenging it would be to support script mode? |
|
@flavorjones I think this should be easy to do. The parsing change itself should be completely straight forward. I think there are three places it matters: in head, in body, and fragment parsing with a Adding a new option makes me think we should consider cleaning up the parse and fragment functions so as to not keep adding additional arguments. That said, these functions are purely internal so maybe that doesn't matter so much. Do you have an opinion on that? |
|
@stevecheckoway I've got a draft branch that cleans up those methods to use keyword arguments, I should be able to clean it up and create a PR in the morning (along with a few other smaller pieces of HTML5 fragment cleanup I also had on a branch). Edit: that PR is #3199 and it does not include additional cleanup. |
) **What problem is this PR intended to solve?** Refactor `Gumbo.parse` and `Gumbo.fragment` to use keyword arguments for parse options (instead of positional arguments). These methods are internal and not part of the public API, so this isn't considered a breaking change. We're changing them to be more extensible going forward. See comments at #3178 for context This PR also - introduces checking for the Gumbo options passed in - takes care to delete deprecated kwarg `max_parse_errors` - cleans up options passed around in tests **Have you included adequate test coverage?** It's a refactor, existing test coverage should be sufficient. **Does this change affect the behavior of either the C or the Java implementations?** No behavior changes, but the HTML5 parser is only available in CRuby.
flavorjones
changed the title
noscript Tags as Script Enabled
Nokogiri parses
<noscript>tags as script disabled mode.Could you consider adding a option in the parsing settings to handle
<noscript>tags as script is enabled mode?This could allow for more flexible parsing depending on the user's needs.
Ref: https://html.spec.whatwg.org/multipage/scripting.html#the-noscript-element
The text was updated successfully, but these errors were encountered: