builder requires textwrappers for valid utf8 in jruby, not in mri (1.5.6-rc2)

[ahmeij]

To be able to encode valid utf8 text wrappers must be used under jruby at the moment, see below example:

code

# coding: utf-8
require 'nokogiri'
puts "Nokogiri #{Nokogiri::VERSION}"
puts "No text wrapper:"
puts Nokogiri::XML::Builder.new(encoding: "UTF-8") { |xml| xml.test "test ﺵ " }.to_xml
puts "With text wrapper:"
puts Nokogiri::XML::Builder.new(encoding: "UTF-8") { |xml| xml.test { xml.text "test ﺵ " }}.to_xml

output Jruby 1.7.0

Nokogiri 1.5.6.rc2
No text wrapper:
<?xml version="1.0" encoding="UTF-8"?>
<test>test ? </test>
With text wrapper:
<?xml version="1.0" encoding="UTF-8"?>
<test>test ﺵ </test>

output MRI 1.9.3

Nokogiri 1.5.6.rc2
No text wrapper:
<?xml version="1.0" encoding="UTF-8"?>
<test>test ﺵ </test>
With text wrapper:
<?xml version="1.0" encoding="UTF-8"?>
<test>test ﺵ </test>

[ahmeij]

I tried to find the cause and as far as I can determine the call to encode_special_chars causes the problem, however I have yet to find out what the root cause exactly is.

[jvshahid]

I cannot reproduce this problem on master. Can you try v1.5.6.rc3 and report if the problem still exists.

[jvshahid]

I'll close this issue. Please feel free to reopen if the problem still exists. I also added a test to make sure that we don't have regression in the future.

[ahmeij]

I cannot reproduce the problem on rc3, thanks!