-
-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configuration of XSLT security #1789
base: main
Are you sure you want to change the base?
Conversation
@maths22 Thank you for submitting this! And apologies for my slow reply. Will look at it and optimistically would like to ship in v1.11.0 (see milestone). |
I just rebased this off current |
Again, apologies for the long delay in reviewing this and providing feedback. There are a few things about this PR that I'd like to change:
If you're not interested in working on this PR, given the long time delay, I understand. But please let me know if you think you'll be able to work on it? Otherwise I'll keep it open and hopefully find time to address some of this feedback. |
Sorry for the big delay here. I've just pushed up a new version that I think exposes a more idiomatic ruby API, has more logical defaults, and checks that the underlying library gets all the config params as expected. (I'm starting to work on getting nokogiri-xmlsec-instructure passing the build inside nokogiri proper, and currently this xmlsec stuff is shoved into that library where it definitely doesn't belong) |
@maths22 ❤️ ❤️ ❤️ Thanks for tackling this and the nokogiri-xmlsec integration. |
No description provided.