Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up error handling in the C extension. #2096

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Clean up error handling in the C extension. #2096

wants to merge 5 commits into from

Commits on Oct 13, 2020

  1. cleanup: no need to check for HAVE_RUBY_UTIL_H in C extension 

    which was introduced in ruby v1_9_0_3
    @flavorjones
    flavorjones committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    6ac0384 View commit details
    Browse the repository at this point in the history

  2. info: add libxml2 version information to extconf have_func calls 

    this will be useful to do some cleanup when we eventually decide to
bump our libxml2 dependency.
    @flavorjones
    flavorjones committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    17e0439 View commit details
    Browse the repository at this point in the history

  3. cleanup: use have_func to check for vasprintf 

    and
- remove platform-specific "-D" flags
- remove `vasprintf_free`
- change calls to `vasprintf_free` to call `free`
    @flavorjones
    flavorjones committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    b329a7c View commit details
    Browse the repository at this point in the history

  4. cleanup: fix xml_node.c type cast warning

    @flavorjones
    flavorjones committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    b76ee14 View commit details
    Browse the repository at this point in the history

  5. fix: address memory leak when xpath evaluation raises an error 

    also ensure CRuby raises an XML::XPath::SyntaxError on xpath function
errors (like JRuby). previously CRuby raised a RuntimeError.

Related to #1610 and #1882.
    @flavorjones
    flavorjones committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    426fd89 View commit details
    Browse the repository at this point in the history