feat(cruby): support line numbers larger than a short #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flavorjones I just came across this problem parsing an aeronautical XML file which counts a whopping 581857 lines. For audits, I have to reference the source node lines, so short doesn't really cut it. Big thanks for this PR! (And hope a fresh release will be cut soonish.) |
|
@svoop Yes, a new release will be out in the next week or two at most. (I want one in before we introduce Ruby 3.1 support.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
As noted in #1493, #1617, #1505, #1003, and #533, libxml2 has not historically supported line numbers greater than a
short int. Starting in libxml v2.9.0, setting the parse optionBIG_LINESwould allow tracking line numbers in longer documents.Specifically this PR makes the following changes:
BIG_LINESparse option by default which will allowNode#lineto return large integersNode#line=to set large line numbers on text nodesFixes #1764
Have you included adequate test coverage?
Yes!
Does this change affect the behavior of either the C or the Java implementations?
JRuby's Xerces-based implementation did not suffer from this particular shortcoming, although its line number functionality is questionable in other ways (see #2177 / b32c875).